autoscaler
autoscaler copied to clipboard
kubernetes
Remove obsolete upper bound check
What type of PR is this?
/kind bug
What this PR does / why we need it:
This check is already done in https://github.com/kubernetes/autoscaler/blob/92c182feda0a08a7ff594bff17f457713294f61b/cluster-autoscaler/core/scaleup/orchestrator/orchestrator.go#L437-L447 so we don't have to do it again.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Welcome @jriedel-ionos!
It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/autoscaler has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @jriedel-ionos. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@piepmatz: changing LGTM is restricted to collaborators
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Giving LGTM (to merge) as the Owner of ionoscloud approved this PR.
/lgtm
CC @feiskyer PTAL!
Owners of ionoscloud cloud provider are not Kubernetes members, so they can't approve the PR. (like @piepmatz gave LGTM but it didn't apply).
As they reviewed the PR, so can we merge this PR?
@gjtempleton @MaciekPytel @x13n PTAL!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jriedel-ionos, piepmatz, x13n
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~cluster-autoscaler/OWNERS~~ [x13n]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@x13n / @Shubham82 will this be included in the next 1.31.x patch release?
@x13n / @Shubham82 will this be included in the next 1.31.x patch release?
IMO, we can cherry-pick these changes(as it is a bug fix) to the supported CA releases (CA 1.28 - CA 1.31).
Let's wait for other members' opinions. cc @x13n @piepmatz WDYT?
@Shubham82 we're hoping to get the next 1.31 CA release to include this fix. any older versions would be nice as well
@Shubham82 we're hoping to get the next 1.31 CA release to include this fix. any older versions would be nice as well
Yeah, if this bug exists in the previous CA releases(supported) then it will be good to fix it in those releases.
Cherrypicking makes sense to me.
/cherry-pick cluster-autoscaler-release-1.31 /cherry-pick cluster-autoscaler-release-1.30 /cherry-pick cluster-autoscaler-release-1.29
@x13n: new pull request created: #7500
In response to this:
Cherrypicking makes sense to me.
/cherry-pick cluster-autoscaler-release-1.31 /cherry-pick cluster-autoscaler-release-1.30 /cherry-pick cluster-autoscaler-release-1.29
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@x13n: new pull request created: #7501
In response to this:
Cherrypicking makes sense to me.
/cherry-pick cluster-autoscaler-release-1.31 /cherry-pick cluster-autoscaler-release-1.30 /cherry-pick cluster-autoscaler-release-1.29
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@x13n: new pull request created: #7502
In response to this:
Cherrypicking makes sense to me.
/cherry-pick cluster-autoscaler-release-1.31 /cherry-pick cluster-autoscaler-release-1.30 /cherry-pick cluster-autoscaler-release-1.29
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.