autoscaler
autoscaler copied to clipboard
kubernetes
vpa - fix checkpoint gc of unknown recommenders
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes the unintentional deletion of VPA checkpoints if using multiple recommenders
Which issue(s) this PR fixes:
Fixes #6387
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: BojanZelic / name: Bojan Zelic (9cb48ea0c752b2797d887717922c900d71765565, c8e87769f427aa908cc42c59fa80241001b45012, 2db8e36f2804c4782972a63afa91ee6c76930b64, b7be1dd3e5c6d5fff1a11d7cb845a5eda7a4b959, bc83411e2e955be99827682fee428c7a7476fbd8, 5fb97bf03b4a30009c3d29329be59418d4f93cd5)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @BojanZelic!
It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/autoscaler has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @BojanZelic. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
(I'm not an owner of this code and my review is meaningless) This code seems fine to me. It seems worth getting tests running and getting eyes from someone with actual review powers to look at it
Hey! Are you still willing to work on this PR? I'd like to get this bug fixed
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: BojanZelic, heybronson, voelzmo, XiangningLi
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~vertical-pod-autoscaler/OWNERS~~ [voelzmo]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment