autoscaler icon indicating copy to clipboard operation
autoscaler copied to clipboard

Support GitHub/Prow labeling for issue/PR triage

Open kwiesmueller opened this issue 1 year ago • 10 comments

We're onboarding new contributors who are looking for issues and PRs to work on. To make it easier for new folks to onboard to a certain area I'd like to suggest that we open up the selection of area labels so issues and PRs can be tagged as cluster-autoscaler, vertical-pod-autoscaler, addon-resizer by people more easily.

I'd recommend using the /area command.

To do this it should be enough that we rename the existing labels to have the area/ prefix. More testing is needed, but we'll need help from an existing maintainer.

/kind cleanup /cc @mwielgus

kwiesmueller avatar Jun 19 '23 18:06 kwiesmueller

I like the idea of allowing people to tag issues.

jbartosik avatar Jun 22 '23 09:06 jbartosik

@kwiesmueller is there any update on this issue?

Shubham82 avatar Jan 12 '24 10:01 Shubham82

I didn't get a chance to work on this. Feel free to pick it up if interested.

kwiesmueller avatar Jan 12 '24 14:01 kwiesmueller

I think maintainers(owners of the autoscaling repo) have the right to add labels.

Shubham82 avatar Jan 15 '24 08:01 Shubham82

cc @mwielgus @gjtempleton @MaciekPytel could you please take a look?

Shubham82 avatar Jan 15 '24 08:01 Shubham82

/triage accepted

Shubham82 avatar Jan 15 '24 08:01 Shubham82

Yeah, it'll require some work from a repo admin.

Bits that I think will need to be done and who can do them:

  • [ ] Create new versions of existing labels with area/ prefix (Needs to be done by a repo admin)
  • [ ] Update auto-labelling of PRs/issues to use the new labels - probably want to cherry-pick this back to all currently supported release branches to ensure consistency going forward (PRs from anyone can cover this.)
  • [ ] (Not sure if worth doing this/can we do it programmatically?) Update past issues/PRs to migrate labels to ensure consistency across PRs/issues. (Addition of new labels should be doable by anyone, I think removal of old ones would have to be a repo admin?)

Anything people think is missing here and any thoughts on whether point 3 is worth doing?

gjtempleton avatar Jan 15 '24 09:01 gjtempleton

Yeah, it'll require some work from a repo admin.

Bits that I think will need to be done and who can do them:

  • [ ] Create new versions of existing labels with area/ prefix (Needs to be done by a repo admin)
  • [ ] Update auto-labelling of PRs/issues to use the new labels - probably want to cherry-pick this back to all currently supported release branches to ensure consistency going forward (PRs from anyone can cover this.)
  • [ ] (Not sure if worth doing this/can we do it programmatically?) Update past issues/PRs to migrate labels to ensure consistency across PRs/issues. (Addition of new labels should be doable by anyone, I think removal of old ones would have to be a repo admin?)

Anything people think is missing here and any thoughts on whether point 3 is worth doing?

Thanks @gjtempleton, It sounds good to me.

Shubham82 avatar Jan 16 '24 07:01 Shubham82

/remove-kind bug /kind feature

Shubham82 avatar Jan 16 '24 07:01 Shubham82

Overall this would be great to have!

Anything people think is missing here and any thoughts on whether point 3 is worth doing?

I'm wondering if we would get this for free if instead of creating new labels we would rename the existing ones?

voelzmo avatar Jan 16 '24 09:01 voelzmo

I'm wondering if we would get this for free if instead of creating new labels we would rename the existing ones?

Looks like the answer is yes. I've just experimented with the helm-charts label renaming it to area/helm-charts and carries over.

Next question I guess is which labels we want to make this change to, just the relevant sub-projects contained within the repo?

gjtempleton avatar Jan 22 '24 14:01 gjtempleton

Hi @gjtempleton @voelzmo what about the renaming of the following labels:

addon-resizer  -> area/addon-resizer
cluster-autoscaler -> area/cluster-autoscaler
balancer -> area/balancer
core-autoscaler -> area/core-autoscaler
vertical-pod-autoscaler -> area/vertical-pod-autoscaler
vertical-pod-atuoscaler/prometheus -> area/vertical-pod-atuoscaler/prometheus

I checked and selected these labels, if you have any suggestions, please let us know.

Thanks!

Shubham82 avatar Jan 23 '24 12:01 Shubham82

sounds good to me. We don't have to get everything on the first shot, so this seems like a good start! Thanks, @Shubham82!

voelzmo avatar Feb 05 '24 08:02 voelzmo

Thanks @voelzmo for taking a look at this.

Shubham82 avatar Feb 05 '24 09:02 Shubham82

OK, I've updated the labels suggested by you @Shubham82 and created #6506 to update the auto-labels applied on the creation of PRs.

gjtempleton avatar Feb 05 '24 23:02 gjtempleton

OK, I've updated the labels suggested by you @Shubham82 and created #6506 to update the auto-labels applied on the creation of PRs.

Thanks, @gjtempleton for the above PR.

Shubham82 avatar Feb 06 '24 05:02 Shubham82