autoscaler icon indicating copy to clipboard operation
autoscaler copied to clipboard

Base parallel scale down implementation

Open x13n opened this issue 2 years ago • 1 comments

Which component this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind feature

What this PR does / why we need it:

Core part of https://github.com/kubernetes/autoscaler/issues/5079 implementation.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This is a follow-up to https://github.com/kubernetes/autoscaler/pull/5229. Only last commit should be reviewed as a part of this PR. It will be on hold until the previous one is merged.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/hold /assign @MaciekPytel @yaroslava-serdiuk

x13n avatar Sep 30 '22 14:09 x13n

/hold cancel

x13n avatar Oct 20 '22 12:10 x13n

Thanks for addressing the comments, LGTM! Just 1 nit, feel free to unhold if you prefer not to address.

/lgtm /approve /hold

towca avatar Oct 24 '22 16:10 towca

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: towca, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 24 '22 16:10 k8s-ci-robot

/hold cancel

x13n avatar Oct 24 '22 18:10 x13n

/lgtm

towca avatar Oct 25 '22 10:10 towca