api

api copied to clipboard

kubectl explain node / oc explain node delivers wrong information

5

**What happened**: I executed `oc explain node` and received wrong information what a node is. It stated that a node is a worker node, which is wrong. The information comes...

erdincay

Fix syntax error

7

zvlb

`Divisor` `resource.Quantity` `omitempty` doesn't make sense

6

https://github.com/kubernetes/api/blob/master/core/v1/types.go#L2309 When you `json.Marshal()` a `ResourceFieldSelector` with undefined `Divisor`, you get `divisor: "0"` This is bad for 2 reasons: 1. `omitempty` is meaningless here 2. According to the docs, `Divisor`...

regnaio

Hi Team, Let's see https://github.com/kubernetes/api/blob/v0.30.0/go.mod ``` // This is a generated file. Do not edit directly. module k8s.io/api go 1.22.0 ``` Please take into account that the Go version specified...

YanniHu1996

It seems like the following field should probably `omitempty`, so that `json.Unmarshal` of an empty `LimitRange` doesn't zero out non-empty `Limits`. https://github.com/kubernetes/api/blob/71385f038c1097af36f3d2f68b415860b866c1f8/core/v1/types.go#L7010 Is there any reason this is not `omitempty`?...

colinhoglund