windows-testing icon indicating copy to clipboard operation
windows-testing copied to clipboard

Use retry wrapper to ensure-azcli.sh and run ci-build-azure-ccm::cleanup only if present

Open jrvaldes opened this issue 2 months ago • 6 comments

Azure CLI installation reliability:

  • Added a new function ensure_azcli_with_retry() that attempts to install Azure CLI up to five times with exponential backoff, logging each attempt and showing logs from failed attempts if installation does not succeed.
  • Updated the set_azure_envs() function to use ensure_azcli_with_retry() instead of directly sourcing ensure-azcli.sh, exiting with an error if installation fails.

Cleanup logic:

  • Improved robustness of the cleanup process by checking if capz::ci-build-azure-ccm::cleanup is defined before calling it, and logging a warning if not found.

jrvaldes avatar Oct 29 '25 20:10 jrvaldes

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrvaldes Once this PR has been reviewed and has the lgtm label, please assign claudiubelu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 29 '25 20:10 k8s-ci-robot

Hi @jrvaldes. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 29 '25 20:10 k8s-ci-robot

/ok-to-test

aravindhp avatar Oct 29 '25 21:10 aravindhp

Azure CLI install step passed, Helm is now failed 😄

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_windows-testing/522/pull-e2e-capz-windows-2025-extension/1983641196173463552#1:build-log.txt%3A141

jrvaldes avatar Oct 29 '25 21:10 jrvaldes

pull-e2e-capz-windows-2025-extension is progressing

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_windows-testing/522/pull-e2e-capz-windows-2025-extension/1983644654431637504#1:build-log.txt%3A197

jrvaldes avatar Oct 29 '25 21:10 jrvaldes

/test pull-e2e-capz-windows-2022-extension

jrvaldes avatar Oct 30 '25 01:10 jrvaldes