vsphere-csi-driver
vsphere-csi-driver copied to clipboard
kubernetes-sigs
WIP: Bug Fix for device is already deleted while unmount volume
What this PR does / why we need it: Pr will handle case where device is not found while unmount volume, so NodeUnpublish will succeed in case of device is corrupted or device is already removed.
Testing done:
Release note:
during unmount volume handle case where device is not found.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: nikhilbarge
Once this PR has been reviewed and has the lgtm label, please assign deepakkinni for approval by writing /assign @deepakkinni in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @nikhilbarge. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Build ID: 416
File vanilla build status: SUCCESS
Stage before exit: e2e-tests
Jenkins E2E Test Results:
Ran 34 of 692 Specs in 4530.314 seconds
SUCCESS! -- 34 Passed | 0 Failed | 0 Pending | 658 Skipped
PASS
Ginkgo ran 1 suite in 1h16m35.668234273s
Test Suite Passed
make: Leaving directory `/home/worker/workspace/csi-file-vanilla-pre-check-in/416/vsphere-csi-driver`
File vanilla build status: SUCCESS
Stage before exit: finally
Jenkins E2E Test Results:
------------------------------
Ran 38 of 692 Specs in 7216.775 seconds
SUCCESS! -- 38 Passed | 0 Failed | 0 Pending | 654 Skipped
PASS
Ginkgo ran 1 suite in 2h1m11.609101239s
Test Suite Passed
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: divyenpatel, nikhilbarge
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [divyenpatel]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hello, would it be possible to backport this also to older versions?
@danielkucera Can you confirm the version numbers you need this fix to be back-ported ?
