vsphere-csi-driver
vsphere-csi-driver copied to clipboard
kubernetes-sigs
[WIP] skip shared datastore computations if CNS task for CreateVolume is persisted in the idempotency CR
What this PR does / why we need it: We are finding shared datastores etc. even when the vCenter task for CreateVolume is already registered with improved idempotency. This PR is optimising this code to make sure that heavy computations of finding shared datastore etc. are skipped if task for CreateVolume is already created.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Testing done: A PR must be marked "[WIP]", if no test result is provided. A WIP PR won't be reviewed, nor merged. The requester can determine a sufficient test, e.g. build for a cosmetic change, E2E test in a predeployed setup, etc. For new features, new tests should be done, in addition to regression tests. If jtest is used to trigger precheckin tests, paste the result after jtest completes and remove [WIP] in the PR subject. The review cycle will start, only after "[WIP]" is removed from the PR subject.
Special notes for your reviewer:
Release note:
Optimise CreateVolume code to skip shared datastore computations if CNS task for CreateVolume is already created
Hi @vdkotkar. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Build ID: 1516
Block vanilla build status: SUCCESS
Stage before exit: e2e-tests
Jenkins E2E Test Results:
------------------------------
Ran 1 of 670 Specs in 346.219 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 669 Skipped
PASS
Ginkgo ran 1 suite in 15m25.338348657s
Test Suite Passed
--
------------------------------
Ran 12 of 670 Specs in 4742.703 seconds
SUCCESS! -- 12 Passed | 0 Failed | 0 Pending | 658 Skipped
PASS
Ginkgo ran 1 suite in 1h20m3.189054931s
Test Suite Passed
--
------------------------------
Ran 40 of 670 Specs in 6679.573 seconds
SUCCESS! -- 40 Passed | 0 Failed | 0 Pending | 630 Skipped
PASS
Ginkgo ran 1 suite in 1h52m27.686977736s
Test Suite Passed
Build ID: 1522
Block vanilla build status: SUCCESS
Stage before exit: e2e-tests
Jenkins E2E Test Results:
------------------------------
Ran 1 of 678 Specs in 328.570 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 677 Skipped
PASS
Ginkgo ran 1 suite in 15m16.600395889s
Test Suite Passed
--
------------------------------
Ran 12 of 678 Specs in 4677.197 seconds
SUCCESS! -- 12 Passed | 0 Failed | 0 Pending | 666 Skipped
PASS
Ginkgo ran 1 suite in 1h19m9.669941758s
Test Suite Passed
--
------------------------------
Ran 40 of 678 Specs in 7198.166 seconds
SUCCESS! -- 40 Passed | 0 Failed | 0 Pending | 638 Skipped
PASS
Ginkgo ran 1 suite in 2h1m12.236729793s
Test Suite Passed
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: deepakkinni, divyenpatel, vdkotkar
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [deepakkinni,divyenpatel]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment