vsphere-csi-driver icon indicating copy to clipboard operation
vsphere-csi-driver copied to clipboard

Volume health check testcases - code fix when injecting psod on esxi hosts

Open sipriyaa opened this issue 3 years ago • 16 comments

What this PR does / why we need it: Code fix for injecting psod on esxi host for Volume health testcases

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes # Code fix for injecting psod on esxi host for Volume health testcases

Testing done: Yes

Special notes for your reviewer: Make Check: sipriya@sipriya-a01 vsphere-csi-driver % sipriya@sipriya-a01 vsphere-csi-driver % golangci-lint run --enable=lll sipriya@sipriya-a01 vsphere-csi-driver % make golangci-lint hack/check-golangci-lint.sh golangci/golangci-lint info checking GitHub for tag 'v1.40.1' golangci/golangci-lint info found version: 1.40.1 for v1.40.1/darwin/amd64 golangci/golangci-lint info installed /Users/sipriya/go/bin/golangci-lint INFO [config_reader] Config search paths: [./ /Users/sipriya/gc-pr-fixes/vsphere-csi-driver /Users/sipriya/gc-pr-fixes /Users/sipriya /Users /] INFO [config_reader] Used config file .golangci.yml INFO [lintersdb] Active 12 linters: [deadcode errcheck gosimple govet ineffassign lll misspell staticcheck structcheck typecheck unused varcheck] INFO [loader] Go packages loading at mode 575 (exports_file|files|imports|name|compiled_files|deps|types_sizes) took 1m4.023123724s INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 98.614181ms INFO [linters context/goanalysis] analyzers took 5m33.9037904s with top 10 stages: buildir: 3m56.58684581s, nilness: 21.974215891s, ctrlflow: 11.515913618s, fact_deprecated: 11.266006934s, printf: 10.695524444s, fact_purity: 7.898943982s, typedness: 7.551733563s, SA5012: 6.856942721s, inspect: 4.259774528s, misspell: 1.929504655s INFO [runner] Issues before processing: 113, after processing: 0 INFO [runner] Processors filtering stat (out/in): cgo: 113/113, filename_unadjuster: 113/113, path_prettifier: 113/113, exclude: 24/24, nolint: 0/1, skip_dirs: 113/113, exclude-rules: 1/24, skip_files: 113/113, autogenerated_exclude: 24/113, identifier_marker: 24/24 INFO [runner] processing took 15.954552ms with stages: nolint: 13.403818ms, autogenerated_exclude: 1.663813ms, path_prettifier: 339.373µs, identifier_marker: 299.67µs, skip_dirs: 114.035µs, exclude-rules: 112.665µs, filename_unadjuster: 8.848µs, cgo: 7.328µs, max_same_issues: 1.379µs, uniq_by_line: 670ns, diff: 545ns, skip_files: 366ns, max_from_linter: 359ns, source_code: 347ns, exclude: 283ns, path_shortener: 267ns, max_per_file_from_linter: 224ns, severity-rules: 223ns, sort_results: 212ns, path_prefixer: 127ns INFO [runner] linters took 37.395863131s with stages: goanalysis_metalinter: 37.379809297s INFO File cache stats: 281 entries of total size 4.5MiB INFO Memory: 950 samples, avg is 572.4MB, max is 2435.0MB INFO Execution took 1m41.529675791s

sipriyaa avatar May 05 '22 14:05 sipriyaa

Hi @sipriyaa. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar May 05 '22 14:05 k8s-ci-robot

Started GC block pre-checkin pipeline... Build Number: 29

svcbot-qecnsdp avatar May 05 '22 14:05 svcbot-qecnsdp

Build ID: 29
GC build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
Ran 9 of 358 Specs in 6316.052 seconds
FAIL! -- 4 Passed | 5 Failed | 0 Pending | 349 Skipped
--- FAIL: TestE2E (6316.17s)
FAIL

Ginkgo ran 1 suite in 1h46m1.941566875s
Test Suite Failed
make: Leaving directory `/home/worker/workspace/gc-csi-pre-checkin-nfs4/Results/29/vsphere-csi-driver`

svcbot-qecnsdp avatar May 05 '22 16:05 svcbot-qecnsdp

Started GC block pre-checkin pipeline... Build Number: 30

svcbot-qecnsdp avatar May 05 '22 16:05 svcbot-qecnsdp

Build ID: 30
GC build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
Ran 4 of 358 Specs in 5087.807 seconds
FAIL! -- 3 Passed | 1 Failed | 0 Pending | 354 Skipped
--- FAIL: TestE2E (5087.93s)
FAIL

Ginkgo ran 1 suite in 1h25m38.34302613s
Test Suite Failed
make: Leaving directory `/home/worker/workspace/gc-csi-pre-checkin-nfs4/Results/30/vsphere-csi-driver`

svcbot-qecnsdp avatar May 05 '22 17:05 svcbot-qecnsdp

Started GC block pre-checkin pipeline... Build Number: 31

svcbot-qecnsdp avatar May 06 '22 05:05 svcbot-qecnsdp

Build ID: 31
GC build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
Ran 1 of 358 Specs in 1114.004 seconds
FAIL! -- 0 Passed | 1 Failed | 0 Pending | 357 Skipped
--- FAIL: TestE2E (1114.11s)
FAIL

Ginkgo ran 1 suite in 19m21.198277805s
Test Suite Failed
make: Leaving directory `/home/worker/workspace/gc-csi-pre-checkin-nfs4/Results/31/vsphere-csi-driver`

svcbot-qecnsdp avatar May 06 '22 05:05 svcbot-qecnsdp

Started GC block pre-checkin pipeline... Build Number: 32

svcbot-qecnsdp avatar May 06 '22 05:05 svcbot-qecnsdp

Build ID: 32
GC build status: SUCCESS 
Stage before exit: finally 
Jenkins E2E Test Results: 

Ran 1 of 358 Specs in 1299.685 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 357 Skipped
PASS

Ginkgo ran 1 suite in 22m36.918697257s
Test Suite Passed
make: Leaving directory `/home/worker/workspace/gc-csi-pre-checkin-nfs4/Results/32/vsphere-csi-driver`

svcbot-qecnsdp avatar May 06 '22 06:05 svcbot-qecnsdp

Started GC block pre-checkin pipeline... Build Number: 33

svcbot-qecnsdp avatar May 06 '22 11:05 svcbot-qecnsdp

Started WCP block pre-checkin pipeline... Build Number: 64

svcbot-qecnsdp avatar May 06 '22 11:05 svcbot-qecnsdp

Build ID: 33
GC build status: SUCCESS 
Stage before exit: finally 
Jenkins E2E Test Results: 

Ran 1 of 358 Specs in 1118.253 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 357 Skipped
PASS

Ginkgo ran 1 suite in 19m11.667963427s
Test Suite Passed
make: Leaving directory `/home/worker/workspace/gc-csi-pre-checkin-nfs4/Results/33/vsphere-csi-driver`

svcbot-qecnsdp avatar May 06 '22 11:05 svcbot-qecnsdp

Build ID: 64
WCP build status: SUCCESS 
Stage before exit: finally 
Jenkins E2E Test Results: 

Ran 1 of 358 Specs in 977.867 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 357 Skipped
PASS

Ginkgo ran 1 suite in 16m55.191091388s
Test Suite Passed
make: Leaving directory `/home/worker/workspace/csi-wcp-pre-check-in-nfs4/Results/64/vsphere-csi-driver`

svcbot-qecnsdp avatar May 06 '22 11:05 svcbot-qecnsdp

Started GC block pre-checkin pipeline... Build Number: 36

svcbot-qecnsdp avatar May 06 '22 16:05 svcbot-qecnsdp

Build ID: 36
GC build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
Ran 1 of 358 Specs in 1354.801 seconds
FAIL! -- 0 Passed | 1 Failed | 0 Pending | 357 Skipped
--- FAIL: TestE2E (1354.90s)
FAIL

Ginkgo ran 1 suite in 23m16.536474076s
Test Suite Failed
make: Leaving directory `/home/worker/workspace/gc-csi-pre-checkin-nfs4/Results/36/vsphere-csi-driver`

svcbot-qecnsdp avatar May 06 '22 17:05 svcbot-qecnsdp

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 23 '22 15:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Sep 22 '22 15:09 k8s-triage-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inamdarm, sashrith, sipriyaa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 26 '22 09:09 k8s-ci-robot

/ok-to-test /lgtm

sashrith avatar Sep 26 '22 09:09 sashrith