vsphere-csi-driver
vsphere-csi-driver copied to clipboard
Onprem GC Create and Delete Test cases Added
What this PR does / why we need it: This PR Adds Guest Cluster Create and Delete Test cases on Onprem setup
Testing done: Yes.
Special notes for your reviewer:
Release note: None
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
- If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
- If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
- Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: inamdarm (b38c55f17bb3345d2d0ad69b19645dee73299bf2, b0c27ff36eb0213f1262d919d0894940b57294b9)
Welcome @inamdarm!
It looks like this is your first PR to kubernetes-sigs/vsphere-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/vsphere-csi-driver has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @inamdarm. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Milind, You need to Sign CLA
Started Vanilla block pre-checkin pipeline... Build Number: 932
Build ID: 932
Block vanilla build status: FAILURE
Stage before exit: e2e-tests
Jenkins E2E Test Results:
JUnit report was created: /home/worker/workspace/csi-block-vanilla-pre-check-in/932/vsphere-csi-driver/tests/e2e/junit.xml
Ran 1 of 312 Specs in 337.976 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 311 Skipped
PASS
Ginkgo ran 1 suite in 6m33.02084642s
Test Suite Passed
--
JUnit report was created: /home/worker/workspace/csi-block-vanilla-pre-check-in/932/vsphere-csi-driver/tests/e2e/junit.xml
Ran 12 of 312 Specs in 5304.083 seconds
SUCCESS! -- 12 Passed | 0 Failed | 0 Pending | 300 Skipped
PASS
Ginkgo ran 1 suite in 1h28m38.985311199s
Test Suite Passed
--
/home/worker/workspace/csi-block-vanilla-pre-check-in/932/vsphere-csi-driver/tests/e2e/vsphere_volume_expansion.go:3268
Ran 40 of 312 Specs in 954.633 seconds
FAIL! -- 38 Passed | 2 Failed | 0 Pending | 272 Skipped
Ginkgo ran 1 suite in 16m9.403287201s
Test Suite Failed
Started Vanilla file pre-checkin pipeline... Build Number: 224
Build ID: 224
File vanilla build status: SUCCESS
Stage before exit: e2e-tests
Jenkins E2E Test Results:
Ran 34 of 312 Specs in 4417.427 seconds
SUCCESS! -- 34 Passed | 0 Failed | 0 Pending | 278 Skipped
PASS
Ginkgo ran 1 suite in 1h14m46.31847079s
Test Suite Passed
make: Leaving directory `/home/worker/workspace/csi-file-vanilla-pre-check-in/224/vsphere-csi-driver`
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: inamdarm, sashrith
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~tests/e2e/OWNERS~~ [sashrith]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale - Mark this issue or PR as rotten with
/lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
@inamdarm: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Reopen this PR with
/reopen - Mark this PR as fresh with
/remove-lifecycle rotten - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
@k8s-triage-robot: Closed this PR.
In response to this:
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied- After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied- After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closedYou can:
- Reopen this PR with
/reopen- Mark this PR as fresh with
/remove-lifecycle rotten- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.