sig-windows-tools icon indicating copy to clipboard operation
sig-windows-tools copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Updates hostprocess kube proxy build script

Open fabi200123 opened this issue 2 years ago • 4 comments

Reason for PR: Updated the hostprocess kube-proxy build script in order to be able to build all kube-proxy versions above v1.22.0 and added the possibility to build only a specific version of kube-proxy

fabi200123 avatar Jul 13 '22 12:07 fabi200123

/assign

jsturtevant avatar Jul 20 '22 17:07 jsturtevant

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fabi200123 Once this PR has been reviewed and has the lgtm label, please ask for approval from jsturtevant by writing /assign @jsturtevant in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 21 '22 08:07 k8s-ci-robot

I agree with the spirit of these changes but have some feedback:

  • Can you update the script to take in $kubeProxyVersion as an environment variable? It seems strange that $flannelVersion is specified via and env var but $kubeProxyVersion would be specified via a command line argument
  • Can you update the description to mention $repository and $flannelVersion too?

marosset avatar Aug 15 '22 23:08 marosset

Change the kube proxy version and the minVersion to be environmental variables too, as well as I added in the description examples on how to use the script with all its parameters. I think that now it should be okay! Let me know if there is something else to be changed

fabi200123 avatar Aug 25 '22 09:08 fabi200123

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 23 '22 09:11 k8s-triage-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fabi200123 Once this PR has been reviewed and has the lgtm label, please ask for approval from jsturtevant by writing /assign @jsturtevant in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Dec 23 '22 13:12 k8s-ci-robot

/lgtm

jsturtevant avatar Jan 03 '23 17:01 jsturtevant

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Feb 02 '23 17:02 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Mar 04 '23 18:03 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 04 '23 18:03 k8s-ci-robot