sig-storage-lib-external-provisioner icon indicating copy to clipboard operation
sig-storage-lib-external-provisioner copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

use patch method instead when update finalizer to PV

Open carlory opened this issue 11 months ago • 7 comments

See https://github.com/kubernetes-csi/external-provisioner/pull/1155#issuecomment-1989048905

/cc @deepakkinni @xing-yang @msau42

carlory avatar Mar 13 '24 03:03 carlory

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar Mar 13 '24 03:03 k8s-ci-robot

/test pull-sig-storage-lib-external-provisioner-unit

carlory avatar Mar 13 '24 06:03 carlory

/assign @jsafrane

xing-yang avatar Mar 14 '24 18:03 xing-yang

A flaking test on TestTopologyParams will be fixed by https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/pull/165

carlory avatar Mar 15 '24 03:03 carlory

I'm looking at another flaking test.

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_sig-storage-lib-external-provisioner/164/pull-sig-storage-lib-external-provisioner-unit/1768450559246864384

fatal error: concurrent map read and map write

It shouldn't relate to changes made by this PR. @deepakkinni

carlory avatar Mar 15 '24 03:03 carlory

/test pull-sig-storage-lib-external-provisioner-unit

carlory avatar Mar 15 '24 03:03 carlory

/lgtm

@jsafrane any concerns switching from update to patch?

xing-yang avatar Mar 28 '24 13:03 xing-yang

/approve

jsafrane avatar Apr 23 '24 08:04 jsafrane

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 23 '24 08:04 k8s-ci-robot

/lgtm cancel

Please update examples/hostpath-provisioner/rbac.yaml with the new permissions.

jsafrane avatar Apr 23 '24 08:04 jsafrane

@jsafrane added.

carlory avatar Apr 23 '24 08:04 carlory

/lgtm

jsafrane avatar Apr 23 '24 10:04 jsafrane