security-profiles-operator
security-profiles-operator copied to clipboard
`spoc record` fixes
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes two bugs with the recorder: First, we now properly handle long executable names. Second, we now track file descriptors per PID, which makes considerably more sense. :)
Which issue(s) this PR fixes:
None
Does this PR have test?
No.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Fix `spoc record` to work with >15 character executable names.
Hi @mhils. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
This PR here is ready. But if I rebase it onto main, nix-build is hanging indefinitely while compiling LLVM on my system. Still need to figure out what's up with that. 🤷
/ok-to-test
Codecov Report
Attention: Patch coverage is 36.36364%
with 7 lines
in your changes are missing coverage. Please review.
Project coverage is 41.14%. Comparing base (
11d77f4
) to head (e6a7ba2
). Report is 174 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2241 +/- ##
==========================================
- Coverage 45.50% 41.14% -4.36%
==========================================
Files 79 107 +28
Lines 7782 15533 +7751
==========================================
+ Hits 3541 6391 +2850
- Misses 4099 8671 +4572
- Partials 142 471 +329
@mhils I think PR needs a rebase. Thanks
Thanks y'all. I have added four more commits with various AppArmor-related fixes that should all be super uncontroversial. :)
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ccojocar, mhils, saschagrunert
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [ccojocar,saschagrunert]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment