security-profiles-operator icon indicating copy to clipboard operation
security-profiles-operator copied to clipboard

SPO Daemonset values are not configurable

Open tuxerrante opened this issue 2 years ago • 8 comments

What happened:

The daemonset CRD is correctly generated in the makefile during a kustomize build targeting the helm folder $(BUILD_DIR)/kustomize build deploy/base-crds -o deploy/helm/crds/crds.yaml https://github.com/kubernetes-sigs/security-profiles-operator/blob/main/Makefile#L182

Then at runtime this daemonset should be generated based on the chart values.yaml to install profiles on the mounted node.

The issue is here, since the daemonset seems to be generated always from static values, ignoring namespace changes, dnsNames changes (#1591 ) taints, tolerations etc...

We have nodes tolerations and taints so we need to schedule only on specific nodes, this is blocking daemonset pods to spawn, which is critical for the basic operation.

What you expected to happen:

SPOD whould have same values as the deployment manager, taking them from the chart values.

How to reproduce it (as minimally and precisely as possible):

Install the chart on a cluster with taints. Pods won't be able to start if not manually patching the daemonset with a toleration. After any pod deletion or daemonset restart the pods won't be scheduled again sine they will be reset.

Anything else we need to know?:

Environment:

Any Kubernetes supporting taints

@stephen-fox maybe?

tuxerrante avatar Mar 31 '23 16:03 tuxerrante

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jun 29 '23 17:06 k8s-triage-robot

Still relevant.

tuxerrante avatar Aug 10 '23 12:08 tuxerrante

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jan 20 '24 02:01 k8s-triage-robot

Still relevant. Edge Nodes are ofter tainted but carry services that need to be recorded or profiled. It is crucial that those workloads can be monitored.

hans-fischer avatar Feb 09 '24 11:02 hans-fischer

@hans-fischer thank you for the ping on this issue. Do you consider to contribute the required changes to fix that problem?

saschagrunert avatar Feb 12 '24 08:02 saschagrunert

I'm afraid I don't have the right skills to work on go-lang code. I have written one small projekt but never understood some basic go-lang prinziples.

hans-fischer avatar Feb 12 '24 09:02 hans-fischer

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 12 '24 09:05 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jun 11 '24 09:06 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Jul 11 '24 09:07 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 11 '24 09:07 k8s-ci-robot