security-profiles-operator icon indicating copy to clipboard operation
security-profiles-operator copied to clipboard
verified publisher icon kubernetes-sigs

apparmor: Add base test coverage

Open pjbgf opened this issue 3 years ago • 4 comments

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The existing AppArmor functionality is not covered by automated tests. This PR introduces a base coverage for the essential use cases: load and unload profiles into the cluster nodes.

Which issue(s) this PR fixes:

Relates https://github.com/kubernetes-sigs/security-profiles-operator/issues/718

Does this PR have test?

Yes.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

pjbgf avatar Aug 06 '22 10:08 pjbgf

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar Aug 06 '22 10:08 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pjbgf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 06 '22 10:08 k8s-ci-robot

Codecov Report

Merging #1074 (ec1415e) into main (fcb0acd) will not change coverage. The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1074   +/-   ##
=======================================
  Coverage   43.92%   43.92%           
=======================================
  Files          49       49           
  Lines        5514     5514           
=======================================
  Hits         2422     2422           
  Misses       2972     2972           
  Partials      120      120

codecov-commenter avatar Aug 06 '22 10:08 codecov-commenter

@pjbgf: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 15 '22 06:11 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 13 '23 07:02 k8s-triage-robot

/remove-lifecycle stale

pjbgf avatar Feb 13 '23 08:02 pjbgf

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 14 '23 09:05 k8s-triage-robot

Closing in favour of https://github.com/kubernetes-sigs/security-profiles-operator/pull/1684.

ccojocar avatar May 16 '23 08:05 ccojocar