secrets-store-csi-driver icon indicating copy to clipboard operation
secrets-store-csi-driver copied to clipboard

Add support to define (overwrite) of securityContext or pod security context

Open cbugneac-nex opened this issue 1 year ago • 10 comments

What this PR does / why we need it: Add support to define (overwrite) SecurityContext for containers & pod security context.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged): Fixes #1437

Special notes for your reviewer:

Link helm chart:

$ helm lint ./
==> Linting ./

1 chart(s) linted, 0 chart(s) failed

TODOs:

  • [ ] squashed commits
  • [x] includes documentation
  • [ ] adds unit tests

cbugneac-nex avatar Feb 12 '24 18:02 cbugneac-nex

Welcome @cbugneac-nex!

It looks like this is your first PR to kubernetes-sigs/secrets-store-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/secrets-store-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Feb 12 '24 18:02 k8s-ci-robot

Hi @cbugneac-nex. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 12 '24 18:02 k8s-ci-robot

/kind feature

cbugneac-nex avatar Feb 12 '24 18:02 cbugneac-nex

Hi @aramase @nilekhc please could you review this PR ?

cbugneac-nex avatar Feb 13 '24 07:02 cbugneac-nex

Hi @aramase @nilekhc @ritazh @tam7t please could you review this PR when you have time ?

cbugneac-nex avatar Feb 14 '24 09:02 cbugneac-nex

Hi @aramase please could you review it once again ?

cbugneac-nex avatar Feb 16 '24 11:02 cbugneac-nex

Hi @aramase @nilekhc @ritazh @tam7t please could you review this PR when you have time ?

cbugneac-nex avatar Feb 27 '24 08:02 cbugneac-nex

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: Constantin07 / name: Constantin Bugneac (813d013e237a57e3d1820d006166cd2ba30dc345, 18c78fb83938ccae6f3a109a1dcfb4def8117ad9)
  • :white_check_mark: login: cbugneac-nex / name: Constantin Bugneac (d00ff30ea22cea94c71ea105b74cbe2fa8caaf09, 5852ec4e5dfb5af6bbe18694896ebfadbea53519, 4e68d06f2f76d464eae197167ad3b85b78ba6e59)

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cbugneac-nex Once this PR has been reviewed and has the lgtm label, please ask for approval from aramase. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 28 '24 16:03 k8s-ci-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 18 '24 05:04 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 17 '24 05:07 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Aug 16 '24 06:08 k8s-triage-robot

Closing this due to inactivity. Please reopen the PR after the comments are addressed.

/close

aramase avatar Aug 20 '24 18:08 aramase

@aramase: Closed this PR.

In response to this:

Closing this due to inactivity. Please reopen the PR after the comments are addressed.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 20 '24 18:08 k8s-ci-robot