secrets-store-csi-driver icon indicating copy to clipboard operation
secrets-store-csi-driver copied to clipboard

test: add bats tests for csi-secrets-store-provider-alibabacloud

Open DahuK opened this issue 2 years ago • 16 comments

What type of PR is this? /kind failing-test

What this PR does / why we need it: add bats test for a new provider from Alibaba Cloud

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged): Fixes #

Special notes for your reviewer: Only the bats tests and testing yaml in this PR, please let me know what should I also prepare like the testing account AK, cluster or something else? Thanks a lot!

TODOs:

  • [X] squashed commits
  • [ ] includes documentation
  • [ ] adds unit tests

DahuK avatar Nov 02 '22 14:11 DahuK

/kind feature

aramase avatar Nov 07 '22 19:11 aramase

/retitle test: add bats tests for csi-secrets-store-provider-alibabacloud

aramase avatar Nov 07 '22 19:11 aramase

@aramase I have refined this to pass our AK/SK from external secret and pass it into mount request from nodePublishSecretRef, please take your time to review this, thanks!

DahuK avatar Nov 16 '22 14:11 DahuK

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Mar 09 '23 02:03 k8s-triage-robot

@aramase @hixichen please check this again when you free, thx!

DahuK avatar Mar 09 '23 07:03 DahuK

/remove-lifecycle stale

aramase avatar Mar 09 '23 18:03 aramase

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.72%. Comparing base (bf86dbf) to head (8783658). Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
- Coverage   36.58%   35.72%   -0.86%     
==========================================
  Files          63       63              
  Lines        4532     3759     -773     
==========================================
- Hits         1658     1343     -315     
+ Misses       2730     2271     -459     
- Partials      144      145       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 08 '23 12:05 codecov-commenter

@aramase @hixichen @ritazh
this has held for a long time, could you please take a time for reviewing this and help to move forward, thanks!

DahuK avatar May 08 '23 12:05 DahuK

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 19 '24 06:01 k8s-triage-robot

/remove-lifecycle stale

aramase avatar Jan 19 '24 18:01 aramase

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 18 '24 18:04 k8s-triage-robot

/remove-lifecycle stale

aramase avatar Apr 19 '24 05:04 aramase

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DahuK, hixichen Once this PR has been reviewed and has the lgtm label, please assign tam7t for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 21 '24 12:04 k8s-ci-robot

@aramase The MR has been on hold for a long time, my apologies for the delayed update. Please review it and let me know if there's anything I need to add.

DahuK avatar Apr 21 '24 12:04 DahuK

@DahuK: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-secrets-store-csi-driver-e2e-windows 8783658a17aae7103c4fd9a2c6b94e71a1247081 link true /test pull-secrets-store-csi-driver-e2e-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Apr 21 '24 12:04 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 20 '24 13:07 k8s-triage-robot