secrets-store-csi-driver
secrets-store-csi-driver copied to clipboard
test: add bats tests for csi-secrets-store-provider-alibabacloud
What type of PR is this? /kind failing-test
What this PR does / why we need it: add bats test for a new provider from Alibaba Cloud
Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):
Fixes #
Special notes for your reviewer: Only the bats tests and testing yaml in this PR, please let me know what should I also prepare like the testing account AK, cluster or something else? Thanks a lot!
TODOs:
- [X] squashed commits
- [ ] includes documentation
- [ ] adds unit tests
/kind feature
/retitle test: add bats tests for csi-secrets-store-provider-alibabacloud
@aramase I have refined this to pass our AK/SK from external secret and pass it into mount request from nodePublishSecretRef, please take your time to review this, thanks!
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale
- Close this PR with
/close
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
@aramase @hixichen please check this again when you free, thx!
/remove-lifecycle stale
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 35.72%. Comparing base (
bf86dbf
) to head (8783658
). Report is 15 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1091 +/- ##
==========================================
- Coverage 36.58% 35.72% -0.86%
==========================================
Files 63 63
Lines 4532 3759 -773
==========================================
- Hits 1658 1343 -315
+ Misses 2730 2271 -459
- Partials 144 145 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@aramase @hixichen @ritazh
this has held for a long time, could you please take a time for reviewing this and help to move forward, thanks!
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale
- Close this PR with
/close
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
/remove-lifecycle stale
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale
- Close this PR with
/close
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
/remove-lifecycle stale
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: DahuK, hixichen Once this PR has been reviewed and has the lgtm label, please assign tam7t for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
@aramase The MR has been on hold for a long time, my apologies for the delayed update. Please review it and let me know if there's anything I need to add.
@DahuK: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
pull-secrets-store-csi-driver-e2e-windows | 8783658a17aae7103c4fd9a2c6b94e71a1247081 | link | true | /test pull-secrets-store-csi-driver-e2e-windows |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale
- Close this PR with
/close
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale