Fixed hook truncation, moved name overrides to globals

[miles-w-3]

What type of PR is this?

/kind bug What this PR does / why we need it:

• Ensures truncation is properly set at 63, for crd hooks, previously unaddressed because suffixes were added
• Adds global nameOverride, fullnameOverride, and commonLabels variables so downstream charts like azure can set one variable instead of setting it twice
  • Still supports setting old variable for backwards compatibility Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged): Fixes #1046

This is a chart update. It should not affect the yaml except for truncation cases that would have previously failed on apply anyway. (When `fullnameOverride` was already 63 chars long and got the suffix appended onto it)

Special notes for your reviewer:

TODOs:

• [ X ] squashed commits
• [ X ] includes documentation
• [ ] adds unit tests

[linux-foundation-easycla[bot]]

• :x: - login: @miles-w-3 / name: Miles . The commit (ba70d9ecee9df957889bd908fa607d212656b136) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[k8s-ci-robot]

Welcome @miles-w-3!

It looks like this is your first PR to kubernetes-sigs/secrets-store-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/secrets-store-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @miles-w-3. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: miles-w-3 Once this PR has been reviewed and has the lgtm label, please assign aramase for approval by writing /assign @aramase in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[aramase]

@miles-w-3 Please see https://github.com/kubernetes-sigs/secrets-store-csi-driver/pull/1047#pullrequestreview-1104875448 for CLA.

I'm closing this PR now due to inactivity. Please feel free to reopen if it's still being worked on.

/close

[k8s-ci-robot]

@aramase: Closed this PR.

In response to this:

@miles-w-3 Please see https://github.com/kubernetes-sigs/secrets-store-csi-driver/pull/1047#pullrequestreview-1104875448 for CLA.

I'm closing this PR now due to inactivity. Please feel free to reopen if it's still being worked on.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.