secrets-store-csi-driver icon indicating copy to clipboard operation
secrets-store-csi-driver copied to clipboard

feat: add namespace configuration for secret-store-csi-driver helm subchart

Open bhanuprakash-1 opened this issue 3 years ago • 11 comments

Adding configurability of namespace for secret-store-csi-driver as asked in this open issue: https://github.com/Azure/secrets-store-csi-driver-provider-azure/issues/575

What type of PR is this? feature

What this PR does / why we need it: There is a requirement of configurability for namespace of this driver and the charts which are dependent on this. Refer to this issue: https://github.com/Azure/secrets-store-csi-driver-provider-azure/issues/575.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged): Fixes #

Special notes for your reviewer:

TODOs:

  • [ ] squashed commits
  • [ ] includes documentation
  • [ ] adds unit tests

bhanuprakash-1 avatar Aug 03 '22 20:08 bhanuprakash-1

CLA Missing ID CLA Not Signed

  • :x: The commit (ededbd30c01cf34235edb4c5cad3ac27c244c8f6, d3be4ebd4474f664233681e51ad9ebce48ff7b91, 8345411158397f45159a18273462f2e58396f1ad, 439b2bd97c094a34cf9c1e5ebbc086822bbf4757, 816694da561eaf6273b1c540d412423796453def). This user is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

Welcome @bhanuprakash-1!

It looks like this is your first PR to kubernetes-sigs/secrets-store-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/secrets-store-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Aug 03 '22 20:08 k8s-ci-robot

Hi @bhanuprakash-1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 03 '22 20:08 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bhanuprakash-1 Once this PR has been reviewed and has the lgtm label, please assign aramase for approval by writing /assign @aramase in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 03 '22 20:08 k8s-ci-robot

Thanks for the PR @bhanuprakash-1. Could you sing CLA? It's required to accept contributions. https://github.com/kubernetes/community/blob/master/CLA.md

nilekhc avatar Aug 03 '22 23:08 nilekhc

/easycla

bhanuprakash-1 avatar Aug 04 '22 05:08 bhanuprakash-1

Thanks for the PR @bhanuprakash-1. Could you sing CLA? It's required to accept contributions. https://github.com/kubernetes/community/blob/master/CLA.md

I have done the required(signed the documente, but it still shows missing CLA Authorization.

bhanuprakash-1 avatar Aug 04 '22 08:08 bhanuprakash-1

/easycla

nilekhc avatar Aug 04 '22 15:08 nilekhc

/easycla

aramase avatar Aug 09 '22 17:08 aramase

/retitle feat: add namespace configuration for secret-store-csi-driver helm subchart

@bhanuprakash-1 could you squash the commits? Hopefully, the CLA issue will be resolved with the new push. If it still doesn't work, you can try reaching out to them here.

aramase avatar Aug 09 '22 18:08 aramase

@bhanuprakash-1: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 19 '22 22:08 k8s-ci-robot

@bhanuprakash-1 Please see https://github.com/kubernetes-sigs/secrets-store-csi-driver/pull/1015#issuecomment-1209704930 for CLA.

I'm closing this PR now due to inactivity. Please feel free to reopen if it's still being worked on.

/close

aramase avatar Oct 13 '22 17:10 aramase

@aramase: Closed this PR.

In response to this:

@bhanuprakash-1 Please see https://github.com/kubernetes-sigs/secrets-store-csi-driver/pull/1015#issuecomment-1209704930 for CLA.

I'm closing this PR now due to inactivity. Please feel free to reopen if it's still being worked on.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 13 '22 17:10 k8s-ci-robot