scheduler-plugins icon indicating copy to clipboard operation
scheduler-plugins copied to clipboard

feature: add MetricsUpdateIntervalSeconds args option in trimaran plugins

Open googs1025 opened this issue 7 months ago • 3 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

This change introduces a new field MetricsUpdateIntervalSeconds, in the TrimaranSpecArgs. This allows users to define their own interval for periodic metrics updates instead of relying on a hardcoded value.

Benefits:

  • Enhanced flexibility: Users can now customize how often metrics are updated based on their specific requirements.
  • Better user experience: Providing configuration options improves the overall usability of the collector."

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

googs1025 avatar May 01 '25 13:05 googs1025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: googs1025 Once this PR has been reviewed and has the lgtm label, please assign huang-wei for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 01 '25 13:05 k8s-ci-robot

Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

Name Link
Latest commit f653d07def0144bf298b33ab10e0b0e73114dd7a
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/681385e45f1213000841cd4c

netlify[bot] avatar May 01 '25 13:05 netlify[bot]

/cc @ffromani @Huang-Wei

googs1025 avatar May 02 '25 00:05 googs1025

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 03 '25 12:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Sep 02 '25 13:09 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Oct 02 '25 13:10 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 02 '25 13:10 k8s-ci-robot