scheduler-plugins icon indicating copy to clipboard operation
scheduler-plugins copied to clipboard

add validate for NodeResourcesAllocatable and Coscheduling plugin

Open googs1025 opened this issue 8 months ago • 3 comments

What type of PR is this?

/kind feature /kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes https://github.com/kubernetes-sigs/scheduler-plugins/issues/887

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

googs1025 avatar Apr 20 '25 14:04 googs1025

Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

Name Link
Latest commit e070ce173f5efc19cd04db634303df9a7bd6af90
Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-scheduler-plugins/deploys/68274341380492000715784e

netlify[bot] avatar Apr 20 '25 14:04 netlify[bot]

/assign @Huang-Wei /PTAL thanks

googs1025 avatar Apr 22 '25 14:04 googs1025

@Huang-Wei @ffromani /PTAL 😄

googs1025 avatar Aug 01 '25 03:08 googs1025

@googs1025 I'm generally in favor and at glance this seems like a good change. I will have a proper review ASAP. Could you please tag a coscheduling plugin author for review?

ffromani avatar Aug 01 '25 06:08 ffromani

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: googs1025, Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 03 '25 23:08 k8s-ci-robot

Could you please tag a coscheduling plugin author for review?

Coscheduling validator changes looks good to me.

Huang-Wei avatar Aug 03 '25 23:08 Huang-Wei