scheduler-plugins
scheduler-plugins copied to clipboard
kubernetes-sigs
Code changes for PEAKS plugin
What type of PR is this?
/kind feature
What this PR does / why we need it:
Code changes for the scheduler plugin for energy efficiency aware scheduling of pods on nodes (prioritize nodes with higher energy efficiency over nodes with lower energy efficiency for pod placement)
Which issue(s) this PR fixes:
Fixes https://github.com/kubernetes-sigs/scheduler-plugins/issues/800
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?
NONE
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Hi @fali007. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for kubernetes-sigs-scheduler-plugins ready!
| Name | Link |
|---|---|
| Latest commit | b3a706725aea5c1bb097a26d9e8d4372abf395b5 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/672adf2d534c5d000880de02 |
| Deploy Preview | https://deploy-preview-810--kubernetes-sigs-scheduler-plugins.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Code changes for PEAKS scheduler plugin with KEP https://github.com/kubernetes-sigs/scheduler-plugins/pull/763
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: fali007 Once this PR has been reviewed and has the lgtm label, please ask for approval from huang-wei. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@fali007 I think tests are still missing in this PR.
- tests are needed (please refer to other plugins to craft both unit test and integration test)
@fali007 I think tests are still missing in this PR.
- tests are needed (please refer to other plugins to craft both unit test and integration test)
Hi @Huang-Wei, we have now added both the unit test cases (with 96.7% code coverage) and integration tests. Kindly review these changes. Thank you.
Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
There are some branch issues in this PR. Hence we created a new PR https://github.com/kubernetes-sigs/scheduler-plugins/pull/829
There are some branch issues in this PR. Hence we created a new PR #829
Close in favor of #829