scheduler-plugins
scheduler-plugins copied to clipboard
kubernetes-sigs
fix: remove vendoring from this repo
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Remove vendor folder, Use go.mod to download dependent code
Which issue(s) this PR fixes:
https://github.com/kubernetes-sigs/scheduler-plugins/issues/760
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Hi @jdtuhui. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.
| Name | Link |
|---|---|
| Latest commit | ada2610bfc246effd2c417643bb6027ed4f8f954 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/66f946bde4c1a80008ef5e99 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jdtuhui Once this PR has been reviewed and has the lgtm label, please assign huang-wei for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@jdtuhui: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-scheduler-plugins-unit-test-master | ada2610bfc246effd2c417643bb6027ed4f8f954 | link | true | /test pull-scheduler-plugins-unit-test-master |
| pull-scheduler-plugins-integration-test-master | ada2610bfc246effd2c417643bb6027ed4f8f954 | link | true | /test pull-scheduler-plugins-integration-test-master |
| pull-scheduler-plugins-verify | ada2610bfc246effd2c417643bb6027ed4f8f954 | link | true | /test pull-scheduler-plugins-verify |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@jdtuhui I think this PR needs some non-trivial work to get all things working - not only tests, but also the Docker builds, codegen, etc. Please let me know if you need some help.
@jdtuhui given we're gonna cut a release in the next week. I guess we can finish this in the new release. WDYT?