scheduler-plugins
scheduler-plugins copied to clipboard
kubernetes-sigs
Add scheduling op to helm chart
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add ability to change nodeSelector, affinity and tolerations of Pods installed via Helm Chart.
Which issue(s) this PR fixes:
Fixes #696
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Adds ability to change NodeSelector, affinity, and tolerance to Helm Chart.
Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.
| Name | Link |
|---|---|
| Latest commit | 70c77ce1990158126060bd5117da0ed898b4d49c |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/661628277cf9d1000848423a |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Could you add a release note in the PR's description? (in the release-notes section)
/lgtm /approve
/hold for release-notes
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Huang-Wei, mochizuki875
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Huang-Wei]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@mochizuki875 could you rebase the PR? (although there is no conflict)
The CI failure is related setup-envtest, which should go away after rebasing.
@Huang-Wei
I've attempted to rebase, but CI failure was not solved.
I've fix setup-envtest version in hack/install-envtest.sh as I think it related to the issue.
FYI: It seems that the same workaround have been taken for #708 that has not been merged yet.
I've fix setup-envtest version in hack/install-envtest.sh as I think it related to https://github.com/kubernetes-sigs/controller-runtime/issues/2720.
You're right, I had a bad memory... I encountered this issue in my another project and commented here. I thought I fixed in this repo but I didn't...
Thanks a lot for the fix!