scheduler-plugins
scheduler-plugins copied to clipboard
kubernetes-sigs
Trimaran test cases for common functions
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Please refer to the issue #636
Which issue(s) this PR fixes:
Fixes #636
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Fixing minor bugs:
- deleting node from ScheduledPodsCache if the pod being deleted is the last one placed on the node
- cleanup cache even if all the cache entries of a node are older
Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.
| Name | Link |
|---|---|
| Latest commit | b4ac4298d2c797f2656996f7b825c680983719d6 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/64fadab32cd0e600085ead58 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @knarayan. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@knarayan: GitHub didn't allow me to assign the following users: atantawi.
Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
In response to this:
/assign @atantawi
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
we don't usually accept merge commits. Can you please rebase?
Yup, there is a prow plugin to fail on merge commit. Let me find the prow config and enable it in scheduler-plugins' CI.
Interesting... this has been enabled https://github.com/kubernetes/test-infra/blob/de81fb13d864ccbd974e73825919a84693dca732/config/prow/plugins.yaml#L1544
/ok-to-test
we don't usually accept merge commits. Can you please rebase?
Done rebase.
https://app.netlify.com/sites/monumental-pastelito-93ebf8/deploys/64fa202cff93053c1af61e95
hi @knarayan, I have checked your branch, and it seems that your branch is far way behind the master, You have to do the rebase to base on top of the master from this sigs repo.
@knarayan it seems that you did a wrong rebase?
I would suggest you create a brand new branch from sigs/scheduler-plugins, and cherry-pick(sorry for involving one more new command) your commit to the new branch, and then you could force push it to the branch here.
@knarayan it seems that you did a wrong rebase?
I would suggest you create a brand new branch from sigs/scheduler-plugins, and cherry-pick(sorry for involving one more new command) your commit to the new branch, and then you could force push it to the branch here.
@zwpaper I suppose that it is fixed now. Thank you.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
@knarayan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-scheduler-plugins-unit-test-master | b4ac4298d2c797f2656996f7b825c680983719d6 | link | unknown | /test pull-scheduler-plugins-unit-test-master |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: knarayan Once this PR has been reviewed and has the lgtm label, please ask for approval from huang-wei. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment