scheduler-plugins icon indicating copy to clipboard operation
scheduler-plugins copied to clipboard
verified publisher icon kubernetes-sigs

add e2e tests to all plugins

Open helayoty opened this issue 3 years ago • 9 comments

It would be ideal to add e2e tests to the current plugins. This can be done by leveraging the e2e-framework sub-project.

  • [ ] e2e framework base implementation (#349 )
  • [ ] tests for plugins

ref: https://github.com/Azure/placement-policy-scheduler-plugins/tree/main/test/e2e

helayoty avatar Feb 07 '22 22:02 helayoty

/assign

helayoty avatar Feb 07 '22 22:02 helayoty

I'm very interested in this, and I'd love to help at least for the noderesourcetopology plugin.

ffromani avatar Feb 25 '22 07:02 ffromani

I'm very interested in this, and I'd love to help at least for the noderesourcetopology plugin.

Thanks, @fromanirh for that. Much needed :) I'm working on finalizing the first step of adding the framework in place and you'll be more than welcome to add tests for plugins then.

I'll update the issue with the PR shortly.

helayoty avatar Mar 01 '22 00:03 helayoty

@fromanirh Here is the first PR. once approved, please go ahead and add tests cases for one or many plugins :) https://github.com/kubernetes-sigs/scheduler-plugins/pull/349

Cc: @Huang-Wei

helayoty avatar Mar 01 '22 03:03 helayoty

thanks @helayoty and sorry for the late notice. I'll take a look ASAP

ffromani avatar Mar 14 '22 15:03 ffromani

(still catching up, sorry!) for the noderesourcetopology plugin, which I'm very interested into, I'm not sure a proper e2e test is possible. The reason for me saying so is the plugin depends on data which is meant to be populated by other cluster components (node agents, daemonsets running on nodes). The problem here is that to have meaningful data, we would need 2+ worker nodes each with 2+ NUMA nodes. If this minimum requirement is not met, there's not real much value added by a e2e test over integration tests. I'm not sure how we can move forward here, so I'm just documenting this requirement for now.

ffromani avatar Apr 11 '22 14:04 ffromani

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 10 '22 15:07 k8s-triage-robot

/remove-lifecycle stale

helayoty avatar Jul 11 '22 01:07 helayoty

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Aug 10 '22 02:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Sep 09 '22 02:09 k8s-triage-robot

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 09 '22 02:09 k8s-ci-robot

/reopen

helayoty avatar Sep 09 '22 02:09 helayoty

@helayoty: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 09 '22 02:09 k8s-ci-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Oct 09 '22 02:10 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 09 '22 02:10 k8s-ci-robot