prow
prow copied to clipboard
kubernetes-sigs
feat: add ghproxy valkey/redis ACL support
add ghproxy support to valkey/redis using ACL (username and password)
when using --redis-address the user can pass the username and password if the redis server has auth
New parameters:
--redis-username=username
--redis-password=password
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: kairoaraujo / name: Kairo Araujo (92f64ead36640dfb0a3a34955ca0dd4365ac006d, b6c87249032e253c316cd2aaff13ab2f958d4cc3)
- :white_check_mark: login: petr-muller / name: Petr Muller (b7aa3eba065d86b55204a01d47dfb4335e57db4a)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @kairoaraujo!
It looks like this is your first PR to kubernetes-sigs/prow 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/prow has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @kairoaraujo. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for k8s-prow ready!
| Name | Link |
|---|---|
| Latest commit | b7aa3eba065d86b55204a01d47dfb4335e57db4a |
| Latest deploy log | https://app.netlify.com/projects/k8s-prow/deploys/68c5fe70ea007d0008ff7df5 |
| Deploy Preview | https://deploy-preview-433--k8s-prow.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kairoaraujo, petr-muller
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~cmd/ghproxy/OWNERS~~ [petr-muller]
- ~~pkg/OWNERS~~ [petr-muller]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment