prow icon indicating copy to clipboard operation
prow copied to clipboard

`tide` merge queue stalls when unresolved comments exist

Open aevyrie opened this issue 11 months ago • 6 comments

Observed Behavior

When a PR is in the merge queue, it has unresolved comments in GitHub, and the repo branch protection settings require all comments to be resolved before merge, it will gum up the tide merge queue, as the PR is not able to merge.

To most users, the stalled PR looks inexplicable.

Expected Behavior

If a PR cannot merge because it has unmet requirements, it should be ignored.

aevyrie avatar Mar 19 '25 06:03 aevyrie

/kind bug /area tide

petr-muller avatar Apr 17 '25 15:04 petr-muller

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 16 '25 15:07 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Aug 15 '25 16:08 k8s-triage-robot

/remove-lifecycle rotten

aevyrie avatar Aug 17 '25 05:08 aevyrie

Likely related to #269

petr-muller avatar Aug 23 '25 20:08 petr-muller

Yup, these seems like a duplicate root cause.

aevyrie avatar Sep 02 '25 21:09 aevyrie