prow icon indicating copy to clipboard operation
prow copied to clipboard

Support init containers

Open mflendrich opened this issue 8 months ago • 2 comments

I would like to create a Prow job with an init container (to encapsulate initialization that requires privileged: true in a separate container).

The validation that prevents creation of initContainers was added back in 2018 https://github.com/kubernetes-sigs/prow/blob/c7c46cd9c7f03da6cebb4734a2e3f42cddf23459/prow/config/config.go#L559 alongside a restriction that the pod must have exactly one container.

Support for multiple containers has been added in 2020 https://github.com/kubernetes-sigs/prow/commit/a61caf60cafcdacab310d44f249a5f82084e7f91 https://github.com/kubernetes-sigs/prow/commit/f13fc68bf224c9bec8fbc2a67fa192a46b376a05

but the "no initContainers" check remains for reasons that are not immediately clear to me.

Are there technical reasons why the restriction could not be lifted?

mflendrich avatar Mar 17 '25 10:03 mflendrich

At least one thing would be necessary: Spyglass currently lists only "normal" containers when enumerating log artifacts https://github.com/kubernetes-sigs/prow/blob/bb46d596752965bba9d6320ca9b2ef7ea7eb1b6a/pkg/spyglass/artifacts.go#L81

mflendrich avatar Mar 19 '25 14:03 mflendrich

/kind feature

petr-muller avatar Apr 17 '25 15:04 petr-muller

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 16 '25 16:07 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Aug 15 '25 17:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Sep 14 '25 17:09 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 14 '25 17:09 k8s-ci-robot