prow icon indicating copy to clipboard operation
prow copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

PR comment for empty aliases, handle other cases.

Open nikhilnishad-goog opened this issue 9 months ago • 4 comments

Fixes #360

Handle cases as discussed in the issue. Add a PR comment for cases where aliases are empty instead of throwing errors. This is because lot of existing users have empty aliases and their approvals were broken.

nikhilnishad-goog avatar Mar 04 '25 12:03 nikhilnishad-goog

Hi @nikhilnishad-goog. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Mar 04 '25 12:03 k8s-ci-robot

Deploy Preview for k8s-prow ready!

Name Link
Latest commit 85266137ce9f7665c3ea2b0289fe4ff365b39805
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/67c6edce564a660008b86a1f
Deploy Preview https://deploy-preview-390--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 04 '25 12:03 netlify[bot]

/ok-to-test

smg247 avatar Mar 07 '25 14:03 smg247

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jun 05 '25 15:06 k8s-triage-robot

/remove-lifecycle stale

This PR has one minor comment, but fixes rather severe bug. Can we please merge this and follow-up in another PR as suggested?

/lgtm

/cc @cjwagner @petr-muller @stevekuznetsov

tuminoid avatar Aug 04 '25 08:08 tuminoid

/approve

matthyx avatar Aug 04 '25 08:08 matthyx

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matthyx, nikhilnishad-goog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 04 '25 08:08 k8s-ci-robot

/retest

tuminoid avatar Aug 05 '25 07:08 tuminoid