prow icon indicating copy to clipboard operation
prow copied to clipboard

(spyglass/lenses) allow configuration sandbox permissions

Open norrs opened this issue 1 year ago • 3 comments

This provides the ability to configure iframe sandbox permissions pr lense. This allows the operator of the prow installation to define which permissions it trust to each lense.

PR comes from the ideas and discussions in https://github.com/kubernetes-sigs/prow/pull/294

norrs avatar Oct 10 '24 13:10 norrs

Hi @norrs. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 10 '24 13:10 k8s-ci-robot

Deploy Preview for k8s-prow ready!

Name Link
Latest commit 44d009847cc71c2cda6dfb12268eee2c90062026
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/6793b7caaddc96000822fab9
Deploy Preview https://deploy-preview-296--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 10 '24 13:10 netlify[bot]

/ok-to-test

michelle192837 avatar Oct 29 '24 23:10 michelle192837

Do you need anything more from me on this?

norrs avatar Nov 18 '24 11:11 norrs

Closed https://github.com/kubernetes-sigs/prow/pull/294 in favor of this PR. Please note that the referred PR has the background for why this PR was created in the first place.

Doing a ping/cc here from the people who were active in 294 ( @michelle192837 @smg247 @BenTheElder . )

Would be nice if we could get this in? 🙏

norrs avatar Jan 09 '25 18:01 norrs

Thanks for the ping and apologies for the delay, this dropped off my radar ><

I'll review today!

michelle192837 avatar Jan 09 '25 18:01 michelle192837

Seems like we need an approval from cmd/checkconfig/OWNERS: @chases2 , @stevekuznetsov or @cjwagner

norrs avatar Jan 31 '25 23:01 norrs

Those folks are no longer working on Prow unfortunately. I think this should get approval from someone in https://github.com/kubernetes-sigs/prow/blob/main/OWNERS until that OWNERS file is fixed.

(Pulling randomly) @petr-muller or @matthyx ?

michelle192837 avatar Jan 31 '25 23:01 michelle192837

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matthyx, michelle192837, norrs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 01 '25 07:02 k8s-ci-robot