prow
prow copied to clipboard
(spyglass/lenses) allow configuration sandbox permissions
This provides the ability to configure iframe sandbox permissions pr lense. This allows the operator of the prow installation to define which permissions it trust to each lense.
PR comes from the ideas and discussions in https://github.com/kubernetes-sigs/prow/pull/294
Hi @norrs. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for k8s-prow ready!
| Name | Link |
|---|---|
| Latest commit | 44d009847cc71c2cda6dfb12268eee2c90062026 |
| Latest deploy log | https://app.netlify.com/sites/k8s-prow/deploys/6793b7caaddc96000822fab9 |
| Deploy Preview | https://deploy-preview-296--k8s-prow.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/ok-to-test
Do you need anything more from me on this?
Closed https://github.com/kubernetes-sigs/prow/pull/294 in favor of this PR. Please note that the referred PR has the background for why this PR was created in the first place.
Doing a ping/cc here from the people who were active in 294 ( @michelle192837 @smg247 @BenTheElder . )
Would be nice if we could get this in? 🙏
Thanks for the ping and apologies for the delay, this dropped off my radar ><
I'll review today!
Seems like we need an approval from cmd/checkconfig/OWNERS: @chases2 , @stevekuznetsov or @cjwagner
Those folks are no longer working on Prow unfortunately. I think this should get approval from someone in https://github.com/kubernetes-sigs/prow/blob/main/OWNERS until that OWNERS file is fixed.
(Pulling randomly) @petr-muller or @matthyx ?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: matthyx, michelle192837, norrs
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~cmd/checkconfig/OWNERS~~ [matthyx]
- ~~cmd/deck/OWNERS~~ [matthyx,michelle192837]
- ~~pkg/spyglass/OWNERS~~ [matthyx,michelle192837]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment