prow icon indicating copy to clipboard operation
prow copied to clipboard

PR with "Change requested" leads to Tide repeatedly attempting MERGE

Open sdowell opened this issue 1 year ago • 5 comments

What happened:

For a Github PR that has passed all checks but has the Change requested state, Tide repeatedly attempts to MERGE but fails (presumably rejected by Github due to the Change requested state).

What you expected to happen:

I would expect Prow/Tide to be aware of the Change requested state and that it is blocking - and therefore not try to perform MERGE.

How to reproduce it (as minimally and precisely as possible):

  • Create a pull request
  • Request changes on the PR
  • Pass all other checks (e.g. presubmits, lgtm, approve, etc)
  • Observe that Tide repeatedly attempts to perform MERGE and fails

Please provide links to example occurrences, if any:

Here is an example PR and tide history:

  • https://github.com/GoogleContainerTools/kpt-config-sync/pull/210
  • https://oss.gprow.dev/tide-history?repo=GoogleContainerTools%2Fkpt-config-sync&branch=main&pull=210

Anything else we need to know?: N/A


Copied over from https://github.com/kubernetes/test-infra/issues/27750

sdowell avatar Sep 05 '24 23:09 sdowell