prow icon indicating copy to clipboard operation
prow copied to clipboard

cherrypickapproved: implement org-level configuration

Open xmudrii opened this issue 1 year ago • 4 comments

This PR implements the org-level configuration for the cherrypickapproved plugin. Right now, it's possible to configure this plugin only on the repo-level. If you have multiple repos, you have to repeat the config for each repo, which is inefficient and clutters the configuration file, especially if the config is the same for all repos.

With this PR, such a configuration is allowed:

cherry_pick_approved:
  - org: org-name
    branchregexp: '^release/v.*$'
    approvers:
      - ...

The repo-level config has the priority over the org level configuration. This also means that this is not a breaking change, i.e. the existing configurations will continue working as before.

/assign @saschagrunert cc @kubernetes-sigs/release-engineering

xmudrii avatar Aug 16 '24 11:08 xmudrii

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 16 '24 11:08 k8s-ci-robot

Deploy Preview for k8s-prow ready!

Name Link
Latest commit ed8a5a0c7ef060994b05d9cfd0f5f8b7d2177310
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/66bf40069eef93000887ad83
Deploy Preview https://deploy-preview-232--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 16 '24 11:08 netlify[bot]

/test pull-prow-unit-test-race-detector-nonblocking

xmudrii avatar Aug 16 '24 12:08 xmudrii

@xmudrii you might want to take a look at https://github.com/kubernetes-sigs/prow/pull/147 where I'm trying to propose a generic solution that could be applied to all plugins

matthyx avatar Aug 16 '24 16:08 matthyx

In addition to https://github.com/kubernetes-sigs/prow/pull/147, I'd like that we take a different route here, so I'm going to close this PR and start over again if needed. /close

xmudrii avatar Aug 27 '24 13:08 xmudrii

@xmudrii: Closed this PR.

In response to this:

In addition to https://github.com/kubernetes-sigs/prow/pull/147, I'd like that we take a different route here, so I'm going to close this PR and start over again if needed. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 27 '24 13:08 k8s-ci-robot