prow icon indicating copy to clipboard operation
prow copied to clipboard

Implement ConfigTree in approve plugin

Open matthyx opened this issue 1 year ago • 10 comments

https://github.com/kubernetes/test-infra/pull/12440

Fixes #221

matthyx avatar May 13 '24 06:05 matthyx

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar May 13 '24 06:05 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matthyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 13 '24 06:05 k8s-ci-robot

Deploy Preview for k8s-prow ready!

Name Link
Latest commit 748c701d8cb5dcc85a9f30960fcbe5f134735aa3
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/6641b1a141fbc8000870274d
Deploy Preview https://deploy-preview-147--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 13 '24 06:05 netlify[bot]

/test all

matthyx avatar May 13 '24 08:05 matthyx

/retest

matthyx avatar May 13 '24 09:05 matthyx

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 05 '24 21:11 k8s-triage-robot

/remove-lifecycle stale

jihoon-seo avatar Nov 14 '24 04:11 jihoon-seo

@petr-muller since it is almost you and me, are we interested in improving the config structs?

matthyx avatar Feb 07 '25 13:02 matthyx

I am interested in this and think its useful, just never got to a review because it's fairly big.

petr-muller avatar Feb 07 '25 14:02 petr-muller

/area plugins

petr-muller avatar Mar 18 '25 22:03 petr-muller