prow icon indicating copy to clipboard operation
prow copied to clipboard

Fix typos throughout the repository

Open xrstf opened this issue 1 year ago • 7 comments

make verify-spelling didn't find these, but https://github.com/crate-ci/typos did. Sadly configuring typos to properly ignore some of the generated base64 stuff is tedious, so this PR does not attempt to replace the existing spellchecker script.

Most of the fixes are just internal, but 2 external things have changed:

  • One Prometheus metric had a typo in it, ghcache_cache_parititions. I created a new metric with the fixed name, but kept the old one for backwards-compatibility.
  • The validate-supplemental-prow-config-hirarchy check in checkconfig was renamed, but I made it so the old spelling is still accepted.

xrstf avatar Apr 21 '24 14:04 xrstf

Deploy Preview for k8s-prow ready!

Name Link
Latest commit 790b4c5afd9a700e214e2f59973340ee28f028be
Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/663ddf297e36790008bf5251
Deploy Preview https://deploy-preview-125--k8s-prow.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 21 '24 14:04 netlify[bot]

/test pull-prow-unit-test

xrstf avatar Apr 21 '24 15:04 xrstf

/test pull-prow-verify-lint

xrstf avatar Apr 21 '24 15:04 xrstf

/kind cleanup /kind deprecation

xrstf avatar Apr 21 '24 15:04 xrstf

/label tide/merge-method-squash

jihoon-seo avatar Apr 22 '24 01:04 jihoon-seo

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matthyx, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 06 '24 16:05 k8s-ci-robot

Looks good, putting a hold to prevent auto-merging, as for me it's a go

matthyx avatar May 06 '24 16:05 matthyx

/lgtm /unhold

matthyx avatar May 11 '24 20:05 matthyx