node-feature-discovery icon indicating copy to clipboard operation
node-feature-discovery copied to clipboard

Disable enableServiceLinks feature in NFD master pod

Open eero-t opened this issue 3 years ago • 1 comments

What would you like to be added:

spec.enableServiceLinks: false to nfd-master service pod spec.

Why is this needed:

See: https://github.com/kubernetes/kubernetes/issues/92615

(Kubernetes itself is not going to default that to false as that would break its core API compatibility, so each service pod should set that option when service is accessed by its "[.]" DNS name instead of env var IP address.)

eero-t avatar Sep 05 '22 12:09 eero-t

Why not. Even though we're not expecting to see thousands of services in the nfd namespace

marquiz avatar Sep 06 '22 05:09 marquiz

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 05 '22 06:12 k8s-triage-robot

/remove-lifecycle stale

eero-t avatar Dec 07 '22 09:12 eero-t

/assign

AhmedGrati avatar Jan 27 '23 15:01 AhmedGrati