node-feature-discovery icon indicating copy to clipboard operation
node-feature-discovery copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

docs: switch to just-the-docs theme

Open marquiz opened this issue 5 months ago • 4 comments

Replace the unmantained jekyll-rtd-theme

marquiz avatar Jun 11 '25 12:06 marquiz

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
Latest commit bf7902ecfa242b23d02236542d4c7046409b6931
Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-nfd/deploys/68836e7b04d81b0008784ffc
Deploy Preview https://deploy-preview-2174--kubernetes-sigs-nfd.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Jun 11 '25 12:06 netlify[bot]

Quickly hacked together a version menu in the top-bar/header. No styling for example. Check how it looks. A preview in netlify and in my personal repo (you can see that the version menu actually works).

We'd need to update the old versions under gh-pages, too (and probably just drop most of them). That can be done in a separate PR.

/assign @ArangoGutierrez /hold

marquiz avatar Jun 11 '25 12:06 marquiz

We could also try https://github.com/JV-conseil/jekyll-theme-read-the-docs

marquiz avatar Jun 11 '25 13:06 marquiz

LGTM label has been added.

Git tree hash: efe2742c78953f517d1188d5ab49eed820e4a621

k8s-ci-robot avatar Jul 24 '25 09:07 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 24 '25 09:07 k8s-ci-robot

New changes are detected. LGTM label has been removed.

k8s-ci-robot avatar Jul 25 '25 10:07 k8s-ci-robot

SO we close this one @marquiz ??

ArangoGutierrez avatar Jul 25 '25 12:07 ArangoGutierrez

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 25 '25 12:07 k8s-ci-robot

Let's archive this PR. We merged #2204

/close

marquiz avatar Jul 30 '25 12:07 marquiz

@marquiz: Closed this PR.

In response to this:

Let's archive this PR. We merged #2204

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 30 '25 12:07 k8s-ci-robot