node-feature-discovery icon indicating copy to clipboard operation
node-feature-discovery copied to clipboard

Watch features.d changes

Open tkatila opened this issue 10 months ago • 6 comments

What would you like to be added:

Changes in the label files in the features.d directory are now propagated every sleep-interval. I'd like to have it so that NFD worker watches the features.d directory and runs the labeling procedure on every change.

Why is this needed:

We have a use case where a workload requires additional node configuration on top of an extended resource (device plugin). The workload is structured so that a container requests an extended resource and is nodeSelector limited to nodes with a special "configuration complete" label. With the default 60sec sleep duration, there is an additional 1-59 sec delay before the workload is scheduled to a node. For the labels to appear quicker to nodes would make them more convenient to control scheduling.

tkatila avatar Mar 07 '25 08:03 tkatila

Thanks @tkatila for the proposal. I think this makes sense. It could also make it sligthly less racy if we rely on fsnotify events instead of a fixed interval there.

marquiz avatar Mar 12 '25 10:03 marquiz

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jun 10 '25 11:06 k8s-triage-robot

/remove-lifecycle stale

tkatila avatar Jun 12 '25 08:06 tkatila

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 10 '25 08:09 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Oct 10 '25 09:10 k8s-triage-robot

/remove-lifecycle rotten

tkatila avatar Oct 10 '25 10:10 tkatila