kubernetes-sigs
add configurable pagination to nfd-gc
adds command line flag to configure pagination for nfd-gc for issue: https://github.com/kubernetes-sigs/node-feature-discovery/issues/1998
Hi @ivelichkovich. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for kubernetes-sigs-nfd ready!
| Name | Link |
|---|---|
| Latest commit | a7634030de78622db8863bc011f70cb6e696c40b |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6779e65051012a0009dc2181 |
| Deploy Preview | https://deploy-preview-2001--kubernetes-sigs-nfd.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ivelichkovich, ozhuraki Once this PR has been reviewed and has the lgtm label, please assign arangogutierrez for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
I'll update this one with the same stuff as the last PR
Awesome @ivelichkovich, I was just about to comment on this :blush:
@ivelichkovich any update on this? Would be cool to get in the next release
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ivelichkovich would you rebase the PR, or let somebody else pick up this one?
@marquiz: Closed this PR.
In response to this:
Superseded by #2294 /close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.