kubernetes-sigs
Pagination size cmd line arg
What would you like to be added:
configurable pagination for nfd-gc list request via command line arg
configurable pagination for nfd-master informer sync initial list via command line arg
related to this: https://github.com/kubernetes-sigs/node-feature-discovery/pull/1815
Why is this needed:
more control over request behavior to api-server
Thanks @ivelichkovich for the request. Makes sense to me. Simplest solution would be to add a config file option /help
@marquiz: This request has been marked as needing help from a contributor.
Guidelines
Please ensure that the issue body includes answers to the following questions:
- Why are we solving this issue?
- To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
- Does this issue have zero to low barrier of entry?
- How can the assignee reach out to you for help?
For more details on the requirements of such an issue, please see here and ensure that they are met.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.
In response to this:
Thanks @ivelichkovich for the request. Makes sense to me. Simplest solution would be to add a config file option /help
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
so I was actually thinking the MR I linked was adding pagination to nfd-master for its informer cache so I raised an MR adding configurable pagination to the NFD master: https://github.com/kubernetes-sigs/node-feature-discovery/pull/2000
and then here's the MR for configurable pagination to NFD GC: https://github.com/kubernetes-sigs/node-feature-discovery/pull/2001