kubernetes-sigs
Doc: Fix tilt up issue in feature discovering in developer guide
The issue is due to the k3d/kind cluster created by ctlptl will run inside containers(it will serve as the virtual hosts).
Host folders which will be scaned by the nfd feature discovery should be mounted into the container ( the virtual host). otherwise the nfd-worker container which run inside the virtual host will just see the default base image rootfs /boot, /lib folders, which are usually empty, leads to the discovey failure.
Hi @ChaoyiHuang. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for kubernetes-sigs-nfd ready!
| Name | Link |
|---|---|
| Latest commit | d08ea5ee118a13b2daa00a904118173e029fcf8f |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/67243dd78ece5d0008f196bb |
| Deploy Preview | https://deploy-preview-1889--kubernetes-sigs-nfd.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Fixes: https://github.com/kubernetes-sigs/node-feature-discovery/issues/1855
Thank you @ChaoyiHuang for the patch. One nit: could you wrap the lines (like the rest of the file)? Other than that looks good to me.
@fmuyassarov any further comments?
/ok-to-test
One nit: could you wrap the lines
Oh the CI (mdlint) was nitting about the same thing, and a few others
One nit: could you wrap the lines
Oh the CI (mdlint) was nitting about the same thing, and a few others
yeah, fixed.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ChaoyiHuang, marquiz
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [marquiz]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
LGTM label has been added.