node-feature-discovery
node-feature-discovery copied to clipboard
nfd-worker: Add an option to disable setting the owner references
In some cases it's desirable to control automatic garbage collection of NodeFeature object.
Add an option to disable setting the owner references to Pod for NodeFeature object.
Closes: #1817
Hi @ozhuraki. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for kubernetes-sigs-nfd ready!
| Name | Link |
|---|---|
| Latest commit | 20ef877ab196409e3c1ab2d23b8d7322cf9f6708 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/674886f291f0e5000850a7cf |
| Deploy Preview | https://deploy-preview-1860--kubernetes-sigs-nfd.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/ok-to-test
@marquiz Thanks! Updated, please take a look
@marquiz Thanks! Updated, please take a look
/retest ping @ArangoGutierrez
@fmuyassarov
Apologies for a delay. Thanks, updated, please take a look
/remove-approve
@marquiz
Thanks, updated. Please take a look
@marquiz
Thanks, updated. Please take a look
@marquiz
Thanks, done.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: marquiz, ozhuraki
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [marquiz]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/milestone v0.17
ping @ArangoGutierrez
/assign @TessaIO
/lgtm
LGTM label has been added.