node-feature-discovery icon indicating copy to clipboard operation
node-feature-discovery copied to clipboard

nfd-worker: Add an option to disable setting the owner references

Open ozhuraki opened this issue 1 year ago • 6 comments

In some cases it's desirable to control automatic garbage collection of NodeFeature object.

Add an option to disable setting the owner references to Pod for NodeFeature object.

Closes: #1817

ozhuraki avatar Aug 30 '24 15:08 ozhuraki

Hi @ozhuraki. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 30 '24 15:08 k8s-ci-robot

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
Latest commit 20ef877ab196409e3c1ab2d23b8d7322cf9f6708
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/674886f291f0e5000850a7cf
Deploy Preview https://deploy-preview-1860--kubernetes-sigs-nfd.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 30 '24 15:08 netlify[bot]

/ok-to-test

marquiz avatar Sep 18 '24 18:09 marquiz

@marquiz Thanks! Updated, please take a look

ozhuraki avatar Sep 25 '24 13:09 ozhuraki

@marquiz Thanks! Updated, please take a look

ozhuraki avatar Oct 11 '24 10:10 ozhuraki

/retest ping @ArangoGutierrez

marquiz avatar Nov 01 '24 11:11 marquiz

@fmuyassarov

Apologies for a delay. Thanks, updated, please take a look

ozhuraki avatar Nov 26 '24 12:11 ozhuraki

/remove-approve

marquiz avatar Nov 26 '24 12:11 marquiz

@marquiz

Thanks, updated. Please take a look

ozhuraki avatar Nov 26 '24 13:11 ozhuraki

@marquiz

Thanks, updated. Please take a look

ozhuraki avatar Nov 28 '24 13:11 ozhuraki

@marquiz

Thanks, done.

ozhuraki avatar Nov 28 '24 15:11 ozhuraki

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, ozhuraki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 29 '24 09:11 k8s-ci-robot

/milestone v0.17

marquiz avatar Dec 12 '24 17:12 marquiz

ping @ArangoGutierrez

marquiz avatar Dec 12 '24 17:12 marquiz

/assign @TessaIO

marquiz avatar Dec 13 '24 10:12 marquiz

/lgtm

TessaIO avatar Dec 13 '24 11:12 TessaIO

LGTM label has been added.

Git tree hash: da04c7d02696d991746b1744f69e72aa95f57940

k8s-ci-robot avatar Dec 13 '24 11:12 k8s-ci-robot