kubernetes-sigs
Add Status to NodeFeature CRD
Hi @ozhuraki. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ozhuraki Once this PR has been reviewed and has the lgtm label, please assign marquiz for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Deploy Preview for kubernetes-sigs-nfd ready!
| Name | Link |
|---|---|
| Latest commit | 5fe453d22e120c56753b2724ea5a299aa69d108a |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/66aa857773e5b100081aa5d3 |
| Deploy Preview | https://deploy-preview-1664--kubernetes-sigs-nfd.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@ozhuraki Are you planning to add some e2e tests for this feature? I think they're important in this use case.
@ArangoGutierrez
Thanks! Updated, please take a look
@ozhuraki could you rebase, sorry it took me so long, I have been swamped by other stuff
@ArangoGutierrez
Sorry for a delay, missed your coments and thanks for the input.
Converted status to a subresource, please take a look.