node-feature-discovery
node-feature-discovery copied to clipboard
kubernetes-sigs
Feat integrate spiffe
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Deploy Preview for kubernetes-sigs-nfd ready!
| Name | Link |
|---|---|
| Latest commit | ef2093a13af9a9786d2b00068dcb38a33fa6e94e |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6541464369b15500083ccaff |
| Deploy Preview | https://deploy-preview-1434--kubernetes-sigs-nfd.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: AhmedGrati Once this PR has been reviewed and has the lgtm label, please assign arangogutierrez for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
@ArangoGutierrez still waiting for review on the design document #1444
@AhmedGrati Design doc approved, let's push this forward
@AhmedGrati Design doc approved, let's push this forward
Hey @ArangoGutierrez, This is my new account as @AhmedGrati was locked out! Sure, I will return to work on this once #1592 is merged.
@AhmedGrati Design doc approved, let's push this forward
Hey @ArangoGutierrez, This is my new account as @AhmedGrati was locked out! Sure, I will return to work on this once #1592 is merged.
What did you do to get locked out of your account :P jajajaj . been there no worries. after pushing really hard you get someone on the line, don't loose faith
What did you do to get locked out of your account :P jajajaj . been there no worries. after pushing really hard you get someone on the line, don't loose faith
basically lost everything, recovery codes, mfa device, and ssh keys. GitHub support said that they can't validate my identity cryptographically, so no way...
What did you do to get locked out of your account :P jajajaj . been there no worries. after pushing really hard you get someone on the line, don't loose faith
basically lost everything, recovery codes, mfa device, and ssh keys. GitHub support said that they can't validate my identity cryptographically, so no way...
Damm man, sad to hear that. :(
Since this comes from a KEP, we will have feature gates flags moving forward https://github.com/kubernetes-sigs/node-feature-discovery/pull/1623
@TessaIO should we re-create this PR with your new GitHub account?
Yes @ArangoGutierrez. As soon as my current PRs are merged, I'll proceed to this one!