node-feature-discovery icon indicating copy to clipboard operation
node-feature-discovery copied to clipboard

nfd-topology-updater only tracks resources it discovered during startup

Open PiotrProkop opened this issue 1 year ago • 8 comments

What happened: Resources that will be managed by NFD topology-updater are only discovered during startup. If a device plugin registers itself with kubelet after NFD topology-updater is already running the NRT will never be updated with new resources.

Resource discovery link Ignoring resources not present during startup link.

It may cause issues when nfd is restarted alongside device plugins, in this case NRT will stop reporting some resources.

What you expected to happen:

When device plugin is created after NFD start new resources should be reported without the need of restarting NFD.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Network plugin and version (if this is a network-related bug):
  • Others:

PiotrProkop avatar Oct 20 '23 10:10 PiotrProkop

/cc @ffromani

PiotrProkop avatar Oct 20 '23 10:10 PiotrProkop

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 30 '24 18:01 k8s-triage-robot

/remove-lifecycle stale

ffromani avatar Jan 30 '24 18:01 ffromani

@PiotrProkop @ffromani are you planning to work on this? Thinking about v0.16 release that is currently projected at the end of March

marquiz avatar Feb 14 '24 11:02 marquiz

@PiotrProkop @ffromani are you planning to work on this? Thinking about v0.16 release that is currently projected at the end of March

I'd love to help but I won't have any bandwidth before early March.

ffromani avatar Feb 14 '24 11:02 ffromani

@PiotrProkop @ffromani are you planning to work on this? Thinking about v0.16 release that is currently projected at the end of March

I'd love to help but I won't have any bandwidth before early March.

I would also be able to start working on that in March, in the meantime I'll try to figure out if there is an easy fix for that or if it requires a bigger refactoring 😄

PiotrProkop avatar Feb 16 '24 09:02 PiotrProkop