nfs-subdir-external-provisioner icon indicating copy to clipboard operation
nfs-subdir-external-provisioner copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Fix onDelete option for subdirectories

Open forselli-stratio opened this issue 2 years ago • 5 comments

Hi, I reopen this PR: https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner/pull/185 since the CLA signatura was not fixed.

forselli-stratio avatar Jul 06 '22 07:07 forselli-stratio

Welcome @forselli-stratio!

It looks like this is your first PR to kubernetes-sigs/nfs-subdir-external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/nfs-subdir-external-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jul 06 '22 07:07 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: forselli-stratio To complete the pull request process, please assign ashishranjan738 after the PR has been reviewed. You can assign the PR to them by writing /assign @ashishranjan738 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 06 '22 07:07 k8s-ci-robot

@humblec @ashishranjan738 : could you please 🙏 approve and merge this? I really need this fix urgently. Thanks in advance.

rmoreas avatar Aug 26 '22 12:08 rmoreas

/assign @yonatankahana

humblec avatar Aug 31 '22 08:08 humblec

Why is this taking so long?

rmoreas avatar Sep 17 '22 18:09 rmoreas

Anyone can check this PR?

forselli-stratio avatar Nov 18 '22 13:11 forselli-stratio

@yonatankahana @humblec can someone merge this?

Queuecumber avatar Nov 20 '22 16:11 Queuecumber

/approve /lgtm

yonatankahana avatar Nov 24 '22 13:11 yonatankahana

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: forselli-stratio, yonatankahana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 24 '22 13:11 k8s-ci-robot