nfs-subdir-external-provisioner icon indicating copy to clipboard operation
nfs-subdir-external-provisioner copied to clipboard

Fix onDelete option for subdirectories

Open Opulski opened this issue 2 years ago • 6 comments

fixes issue #127 by using the full nfs path set in p.path and replacing the host path of the nfs server with the mount path using strings.Replace instead of just joining the basePath

Opulski avatar Mar 25 '22 18:03 Opulski

CLA Not Signed

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Opulski To complete the pull request process, please assign ashishranjan738 after the PR has been reviewed. You can assign the PR to them by writing /assign @ashishranjan738 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 25 '22 18:03 k8s-ci-robot

hi @Opulski, can you fix your CLA signiture?

yonatankahana avatar May 29 '22 17:05 yonatankahana

hi @Opulski, can you fix your CLA signiture?

Signed it again

Opulski avatar Jun 03 '22 06:06 Opulski

Could this fix be released asap please. Thanks!

rmoreas avatar Jul 27 '22 16:07 rmoreas

@Opulski seems that the CLA authorization is still missing. Can you fix it?

rmoreas avatar Aug 14 '22 14:08 rmoreas

Closing this in favor of the new PR (221)

kmova avatar Aug 31 '22 13:08 kmova