nfs-ganesha-server-and-external-provisioner icon indicating copy to clipboard operation
nfs-ganesha-server-and-external-provisioner copied to clipboard

Add persistence.existingClaim to nfs-ganesha-external-provisioner

Open almahmoud opened this issue 2 years ago • 3 comments

Adds the feature of using an existing PVC for persistence

almahmoud avatar Aug 23 '22 17:08 almahmoud

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: almahmoud / name: Alexandru Mahmoud (3b34189698c922360eea89afc1d4de8aceff0131)

Welcome @almahmoud!

It looks like this is your first PR to kubernetes-sigs/nfs-ganesha-server-and-external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/nfs-ganesha-server-and-external-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Aug 23 '22 17:08 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: almahmoud Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval by writing /assign @jsafrane in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 23 '22 17:08 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 21 '22 17:11 k8s-triage-robot

Still hoping for this to be merged so not stale.

afgane avatar Nov 30 '22 14:11 afgane

/remove-lifecycle stale

afgane avatar Nov 30 '22 14:11 afgane

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: almahmoud, kvaps

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jan 04 '23 08:01 k8s-ci-robot