metrics-server icon indicating copy to clipboard operation
metrics-server copied to clipboard

Document securing connection between kube-apiserver <-> Metrics Server

Open serathius opened this issue 5 years ago • 20 comments

We should do a better job informing users how to secure communication between apiserver and Metrics server. It should mention disabling insecureSkipTLSVerify

/kind documentation /help

serathius avatar Jun 21 '20 10:06 serathius

@serathius: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

We should do a better job informing users how to secure communication between apiserver and Metrics server. It should mention disabling insecureSkipTLSVerify

/kind documentation /help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jun 21 '20 10:06 k8s-ci-robot

I had a repo https://github.com/jenting/secure-metrics-server to deploy metrics-server in secure, hope it would help :smile:

jenting avatar Aug 06 '20 07:08 jenting

Thanks @jenting, it looks really interesting. I will talk with someone more familiar with apimachinery to confirm this is aligned with current best practices. Would you be interested in contributing this to MS documentation?

serathius avatar Aug 06 '20 08:08 serathius

To here https://github.com/kubernetes-sigs/metrics-server/blob/master/FAQ.md#how-to-run-metrics-server-securely, right?

jenting avatar Aug 06 '20 08:08 jenting

Yes, before starting work let me get lgtm from someone from SIG-apimachinery & SIG-security. I think your instructions are very good, still it's could be possible to improve them with some feedback from area experts.

serathius avatar Aug 06 '20 08:08 serathius

@logicalhan, are you know who should we ask about securing kube-apiserver -> extension apiserver communication and what is current recommended approach?

Would it be ok for us to recommend manual certificate creation like described here https://github.com/kubernetes-sigs/metrics-server/blob/master/FAQ.md#how-to-run-metrics-server-securely

serathius avatar Aug 06 '20 08:08 serathius

ping @logicalhan

serathius avatar Aug 25 '20 07:08 serathius

@liggitt probably has a better idea about this than me.

logicalhan avatar Aug 25 '20 16:08 logicalhan

/triage accepted

serathius avatar Nov 15 '20 13:11 serathius

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar Feb 13 '21 14:02 fejta-bot

/remove-lifecycle stale ping @liggitt

serathius avatar Feb 13 '21 14:02 serathius

Would it be ok for us to recommend manual certificate creation like described here https://github.com/kubernetes-sigs/metrics-server/blob/master/FAQ.md#how-to-run-metrics-server-securely

redirect to @deads2k

liggitt avatar Feb 15 '21 15:02 liggitt

ping @deads2k

serathius avatar Mar 17 '21 09:03 serathius

/lifecycle frozen

serathius avatar Jul 17 '21 07:07 serathius

just get the file from all the versions components.yaml add and apply:

 k8s-app: metrics-server

spec:

  containers:

  - args:

    **- --kubelet-insecure-tls**

jmvcollaborator avatar Jun 14 '22 22:06 jmvcollaborator

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot avatar Jun 15 '23 08:06 k8s-triage-robot

/triage accepted

Constantin07 avatar Jun 15 '23 15:06 Constantin07

@Constantin07: The label triage/accepted cannot be applied. Only GitHub organization members can add the label.

In response to this:

/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jun 15 '23 15:06 k8s-ci-robot

/triage accepted

dashpole avatar Aug 10 '23 16:08 dashpole