metrics-server icon indicating copy to clipboard operation
metrics-server copied to clipboard

[release-0.5] cherrypick #1300 kernel bug lead to incorrect cpu usage

Open Cloudzp opened this issue 1 year ago • 14 comments

What this PR does / why we need it: cherrypick https://github.com/kubernetes-sigs/metrics-server/pull/1300 Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Cloudzp avatar Dec 26 '23 12:12 Cloudzp

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Cloudzp Once this PR has been reviewed and has the lgtm label, please assign s-urbaniak for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Dec 26 '23 12:12 k8s-ci-robot

Welcome @Cloudzp!

It looks like this is your first PR to kubernetes-sigs/metrics-server 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/metrics-server has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Dec 26 '23 12:12 k8s-ci-robot

Hi @Cloudzp. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Dec 26 '23 12:12 k8s-ci-robot

/retest

Cloudzp avatar Dec 26 '23 12:12 Cloudzp

@Cloudzp: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Dec 26 '23 12:12 k8s-ci-robot

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: Cloudzp / name: zhangpeng (666c4c3f823bd9d03c740b3f4bb16132ed9b1497)

/retest

Cloudzp avatar Dec 26 '23 12:12 Cloudzp

@Cloudzp: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Dec 26 '23 12:12 k8s-ci-robot

/retest

Cloudzp avatar Dec 26 '23 12:12 Cloudzp

@Cloudzp: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Dec 26 '23 12:12 k8s-ci-robot

/assign @serathius /triage accepted

dashpole avatar Jan 11 '24 17:01 dashpole

@Cloudzp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-metrics-server-verify 666c4c3f823bd9d03c740b3f4bb16132ed9b1497 link true /test pull-metrics-server-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Mar 19 '24 11:03 k8s-ci-robot

Hi, @Cloudzp As mentioned at https://github.com/kubernetes-sigs/metrics-server/pull/1457#issuecomment-2111836177, the release-0.5 branch is no longer supported. It is recommended to switch the version of the new branch

yangjunmyfm192085 avatar May 15 '24 08:05 yangjunmyfm192085

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 13 '24 08:08 k8s-triage-robot